From a2d3b605007eca2ff876d94759fba8bf4871925e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gon=C3=A7alo=20Rodrigues?= <guga@Goncalos-MacBook-Pro.local>
Date: Sat, 13 Jun 2026 18:55:38 +0100
Subject: [PATCH] =?UTF-8?q?fix:=20allocation=20chart=20=E2=80=94=20illegal?=
 =?UTF-8?q?=20top-level=20return=20in=20ES=20module?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

`return` at the top level of a <script type="module"> is a SyntaxError
in strict mode, so the entire Three.js chart script was killed before
executing regardless of whether prices were available.

Replaced `if (total <= 0) return` with `if (total > 0) { ... }` wrapping
the full chart body. Also filter out holdings with value=0 before building
the arc geometry so a single un-priced ISIN can't produce a zero-arc slice.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 apps/finance/services/api/main/templates/portfolio.html | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/apps/finance/services/api/main/templates/portfolio.html b/apps/finance/services/api/main/templates/portfolio.html
index 7deba1b..1e36af9 100644
--- a/apps/finance/services/api/main/templates/portfolio.html
+++ b/apps/finance/services/api/main/templates/portfolio.html
@@ -99,10 +99,11 @@ const palette = [
 
 const holdings = [
   {{range $d.Holdings}}{ name: "{{.Name}}", value: {{.CurrentValueCents}} },{{end}}
-];
+].filter(h => h.value > 0);
 
 const total = holdings.reduce((s, h) => s + h.value, 0);
-if (total <= 0) return;
+
+if (total > 0) {
 
 const container = document.getElementById('allocation3d');
 const W = container.clientWidth, H = 380;
@@ -211,6 +212,8 @@ window.addEventListener('resize', () => {
   camera.updateProjectionMatrix();
   renderer.setSize(w2, H);
 });
+
+} // end if (total > 0)
 </script>
 
 {{else}}