admin/homelab
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(finance): portfolio template float64 comparison error

Browse Source 
ge/lt in Go templates cannot mix float64 and untyped int literals.
TotalPCLPct is float64, so replaced `ge $d.TotalPCLPct 0` with
`eq (pctSign $d.TotalPCLPct) "+"` which uses the existing pctSign
helper that already handles the sign check correctly.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Gonçalo Rodrigues 2026-06-13 12:50:31 +01:00
parent c255d7f523
commit 2b98599bcf
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
apps/finance/services/api/main/templates/portfolio.html
View File

@ -19,7 +19,7 @@
<h2>Unrealized P&amp;L</h2> <h2>Unrealized P&amp;L</h2>
<div class="value {{if ge $d.TotalPCLCents 0}}positive{{else}}negative{{end}} animate-counter" <div class="value {{if ge $d.TotalPCLCents 0}}positive{{else}}negative{{end}} animate-counter"
data-target="{{$d.TotalPCLCents}}" data-prefix="€">€0.00</div> data-target="{{$d.TotalPCLCents}}" data-prefix="€">€0.00</div>
<p style="font-size:13px; margin-top:6px; {{if ge $d.TotalPCLPct 0}}color:var(--green){{else}}color:var(--red){{end}};"> <p style="font-size:13px; margin-top:6px; color:{{if eq (pctSign $d.TotalPCLPct) "+"}}var(--green){{else}}var(--red){{end}};">
{{pctSign $d.TotalPCLPct}}{{printf "%.2f" $d.TotalPCLPct}}% {{pctSign $d.TotalPCLPct}}{{printf "%.2f" $d.TotalPCLPct}}%
</p> </p>
</div> </div>
@ -66,6 +66,7 @@
{{if ge .UnrealizedPCLCents 0}}+{{else}}−{{end}}€{{cents (centsAbs .UnrealizedPCLCents)}} {{if ge .UnrealizedPCLCents 0}}+{{else}}−{{end}}€{{cents (centsAbs .UnrealizedPCLCents)}}
</div> </div>
</td> </td>
</tr> </tr>
{{end}} {{end}}
</tbody> </tbody>